search

JoshuaLampert / DispersiveShallowWater.jl

Structure-preserving numerical methods for dispersive shallow water models
https://joshualampert.github.io/DispersiveShallowWater.jl/
MIT License
15 stars 3 forks source link

Run CI on Julia v1.10 #142

Closed JoshuaLampert closed 1 month ago

JoshuaLampert commented 1 month ago

Since Julia v1.11 will be out probably soon and v1.10 will be the new LTS, I would like to run CI also on v1.10.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.57%. Comparing base (1d821a7) to head (23f25bc). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #142 +/- ## ======================================= Coverage 97.57% 97.57% ======================================= Files 20 20 Lines 1569 1569 ======================================= Hits 1531 1531 Misses 38 38 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ranocha commented 1 month ago

Sounds reasonable. However, we still support Julia v1.9 - and I would like to keep it this way unless you have a very good reason not to do so. My motivation for this is mainly that there are people out there who are not power users of Julia like we, so they will likely have older versions of it. I would like to support them. That's something I have experienced with BSeries.jl.

Thus, we could for example keep one job on Julia v1.9 and move the others to Julia v1.10.

JoshuaLampert commented 1 month ago

Thus, we could for example keep one job on Julia v1.9 and move the others to Julia v1.10.

Sounds good. I added a test, which runs with v1.9 on Ubuntu.

JoshuaLampert commented 1 month ago

What about the Downgrade job? I would run it on v1.10. Do you agree?

ranocha commented 1 month ago

What about the Downgrade job? I would run it on v1.10. Do you agree?

I don't have a strong opinion there. One could argue that the oldest versions of all dependencies will likely be available on the oldest Julia versions, though. But as I said, I'm fine either way

JoshuaLampert commented 1 month ago

Ok, let's keep it on v1.9 for now.

JoshuaLampert commented 1 month ago

Sorry, I mixed up the PRs. I wanted to merge the other one...

JoshuaLampert commented 1 month ago

Are you fine with this PR @ranocha? If yes, I would create a new release. If not, I would first consider your suggestion before creating a new release. Sorry again for not waiting for your review :grimacing: