search

JoshuaLampert / DispersiveShallowWater.jl

Structure-preserving numerical methods for dispersive shallow water models
https://joshualampert.github.io/DispersiveShallowWater.jl/
MIT License
15 stars 3 forks source link

Add `BBMEquation1D` #150

Closed JoshuaLampert closed 1 month ago

JoshuaLampert commented 1 month ago

This is a first step towards supporting a few simpler models, cf. #95.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 99.18699% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.97%. Comparing base (11355c0) to head (256eed5). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/equations/bbm_1d.jl 98.88% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #150 +/- ## ========================================== + Coverage 97.78% 97.97% +0.19% ========================================== Files 18 19 +1 Lines 1667 1776 +109 ========================================== + Hits 1630 1740 +110 + Misses 37 36 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JoshuaLampert commented 1 month ago

I'm totally confused by this error: https://github.com/JoshuaLampert/DispersiveShallowWater.jl/actions/runs/10811172112/job/29990016675?pr=150#step:7:8511 happening in this line: https://github.com/JoshuaLampert/DispersiveShallowWater.jl/blob/11355c045f470c967234cc7a7fc4c11e10424076/src/equations/svaerd_kalisch_1d.jl#L94 Why does it want to convert 3.0 to an Int? And why does this happen all of the sudden (only on Mac)? Any ideas, @ranocha?

ranocha commented 1 month ago

I have no idea - that's very strange indeed

JoshuaLampert commented 1 month ago

I have no idea - that's very strange indeed

Now CI passes again 🤷‍♂️

JoshuaLampert commented 1 month ago

Sorry, CI seems to be a bit weird.