Closed JoshuaLampert closed 1 week ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 97.78%. Comparing base (
6dffbd9
) to head (0a8be27
). Report is 2 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I noticed that we define the pretty printing of some functions twice: Once for the
AnalysisCallback
and once in visualization.jl (and forgot, e.g. ,energy_total_modified
in visualization.jl). In visualization.jl we only have access to the Symbol and not the function since this is what is stored inintegrals(analysis_callback)
, but we can translate it to the function usinggetfield(@__MODULE__, name)
. However, most errors ($L^2$, $L^\infty$ and the conservation error) don't have a corresponding function (the lake-at-rest error on the other hand has). Thus, for simplicity, I just kept the current approach for the errors and define a pretty form in visualization.jl for the errors (this means it is redefined for the lake-at-rest error), but reuse the pretty form from theAnalysisCallback
for the integrals. This meanspretty_form_utf
dispatches a bit strangely on functions and Symbols. I am open for a better suggestion, @ranocha.