search

JoshuaLampert / DispersiveShallowWater.jl

Structure-preserving numerical methods for dispersive shallow water models
https://joshualampert.github.io/DispersiveShallowWater.jl/
MIT License
15 stars 3 forks source link

Use functions from `analysis_integrals` #152

Closed JoshuaLampert closed 1 month ago

JoshuaLampert commented 1 month ago

See the discussion in https://github.com/JoshuaLampert/DispersiveShallowWater.jl/pull/151#discussion_r1753177919. I'm not sure if that's what you had in mind, @ranocha, but this should work, shouldn't it? We know that the functions within cb.affect!.analysis_integrals have the same order as the entries of the NamedTuple ints = integrals(cb). So we can just get the functions from there.

TODO:

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.78%. Comparing base (6ab2051) to head (71d8dce). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #152 +/- ## ======================================= Coverage 97.78% 97.78% ======================================= Files 18 18 Lines 1667 1667 ======================================= Hits 1630 1630 Misses 37 37 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.