search

JoshuaMKW / pyisotools

python library for working with Gamecube ISOs (GCM)
GNU General Public License v3.0
18 stars 9 forks source link

Avoid mirroring tiles diagonally. #6

Closed cristian64 closed 2 years ago

cristian64 commented 2 years ago

It seems this was a regression introduced by https://github.com/cristian64/pyisotools/commit/13b6ec354576973689908f3de66856600f9f8115, where the tile column and the tile row were swapped inadvertently.

Because both the extract and the compile operations were suffering from the same issue, two bads were making a good, and the resulting BNR file after exporting/re-compiling was in fact good. However, the transitory PNG image was corrupted.

Example of a corrupted PNG image:

image

Generated with:

cd pyisotools
python3 -m pyisotools.bnrparser .../GM4E01/files/opening.bnr /tmp/image.png -j EXTRACT
JoshuaMKW commented 2 years ago

Thanks for finding this! I've been inactive working on this project so I'm happy you've taken this initiative to fix the bug.