JoshuaPeddle / Visualizing-Technology-Use-by-Age-and-Region

Comp3100. Team 32. Joshua Peddle & Ethan Mc Donald.
0 stars 1 forks source link

Batch of upgrades to the map. Refactor of frontend.js. #37

Closed JoshuaPeddle closed 2 years ago

JoshuaPeddle commented 2 years ago

Added some error checking to prevent empty searches without a dataset / location selected.

Added a new function clearAllHighlights() to clear the drawing from the map. Added overlay to map displaying percentage value from dataset. Clean up most bugs related to map.

Small addition to the CSS for the leaflet overlay.

Made export button hide when no data is exportable. Implementation a little rough but seems to work.

Reformatted and refactored frontend.js with no major functional changes.

ethantmc commented 2 years ago

This looks awesome. I think this is usable for the video, but I'm going to see if I can do something to differentiate the colours more.

Edit: Looks totally doable, but it's too likely to break things here on the last day. It would be to make the color scaling relative, but that means collecting the values for each region, finding the lowest and the highest, and using that to stretch and fill the color range, like in Visual Computing.

JoshuaPeddle commented 2 years ago

Increasing the contrast between the results a little should still be possible by increasing the value of the d's in getColor().

Good call. That should be doable I think using the setLayerProperty() and getLayerProperty() functions.

Working on both right now.

ethantmc commented 2 years ago

I've removed the validator code and pushed it to this branch, as well. I wrote up this comment earlier but just realized this tab exists. Anyways, I'm going to go get started on the video script, don't worry about it being ready for the video though, I'll just mention it's fixed in the final release,

JoshuaPeddle commented 2 years ago

Sounds good. Just pushed a commit with the overlay working I think. It's as selective as possible and only display info when both datasets are selected, and the region contains data from both datasets,

I was doing some research about caching and it turns out our server is a great candidate since our datasets are static and we have unique URL for each request. I've enabled caching for getRequests() and getUsages() and it seems to be working. Running the same request multiple times does not trigger a mongo search on our server anymore, even after refresh of page.