search

JoshuaStorm / meetable

A free web application for simplifying the process of scheduling individual and group meetings.
https://meetable-us.herokuapp.com/
4 stars 3 forks source link

All times but After=Before should be acceptable `meetRange` values #258

Closed JoshuaStorm closed 7 years ago

JoshuaStorm commented 7 years ago

Currently the front end throws bert alerts for totally legitimate can't meet before and can't meet after such as "12am-1am". They're kinda absurd but still legitimate.

The only time we should throw an error is if Before==After.

This will require a slight backend change as well, since I think I made assumptions about the time as well.

davidmelvin commented 7 years ago

I still don't fully understand what inputting "12am-1am" means from the user point of view, but if i do understand it correctly I don't think we should make this change

JoshuaStorm commented 7 years ago

12am-1am means I only want to meet between 12am and 1am

JoshuaStorm commented 7 years ago

Maybe we should rephrase this the meetRange stuff as "I want to meet between these hours"

JoshuaStorm commented 7 years ago

Actually double checked and the back end code seems like it's good to handle this already.

JoshuaStorm commented 7 years ago

@supert165 Are you still looking t the front end stuff on this?