search

JoshuaStorm / meetable

A free web application for simplifying the process of scheduling individual and group meetings.
https://meetable-us.herokuapp.com/
4 stars 3 forks source link

Pull more than 4 weeks, easyfix. How slow is this for everyone? #270

Closed JoshuaStorm closed 7 years ago

JoshuaStorm commented 7 years ago

Closes #268

This is an easy fix, just asking for all events from GCal...

If this isn't super slow for anyone, I think we should just do this TBH.

Even if it is slow, maybe worth still doing this and just adding the loading indicator thing, if that isn't too hard

shayanmonshizadeh commented 7 years ago

11 seconds for all my calendars. Not bad but enough to make me think something's wrong and refresh the page

davidmelvin commented 7 years ago

It's taking about 7 seconds to load all of my calendars, which I think is a bit too long. Can we do some kind of caching thing to speed it up? If not, we should load 4 weeks at a time when necessary I think

JoshuaStorm commented 7 years ago

Main issue with caching is knowing when the user updated...

Hmmm, my main concern is it'd be pretty difficult to write code to handle all pulling more data reactively in all cases, and I feel like the graders are going to try to break our system by doing far away dates pretty much straight away... Unsure how to approach this

shayanmonshizadeh commented 7 years ago

Other option is to add loading wheel. You guys think we should risk it orrrr?

davidmelvin commented 7 years ago

Do you know how much data is downloaded when you don't put an event # or time limit on the request?

Can't we just add a lastUpdated field that tracks the last date the user downloaded all their data successfully? or do you mean something else? I think the more difficult issue is that a user can change the details of an event that we cached and it wouldn't be shown on our calendar

I say we go loading wheel for now

JoshuaStorm commented 7 years ago

I'm down for loading wheel.. Would you be down to implement that on top this branch @davidmelvin? I would but I'm kinda clueless to how to go about it

shayanmonshizadeh commented 7 years ago

2 months is 8 seconds. Enough to make me wait before pressing refresh. I think this is good

JoshuaStorm commented 7 years ago

Good for merge you mean? I guess that is worst-case-scenario wait time so maybe it's alright? Wanna do 1.5 months maybe???

shayanmonshizadeh commented 7 years ago

Yes good for merge. Yeah I don't think it's a big deal we'll just say in the product guide you might have to wait a couple of seconds