search

JoshuaStorm / meetable

A free web application for simplifying the process of scheduling individual and group meetings.
https://meetable-us.herokuapp.com/
4 stars 3 forks source link

Move from routes to onRendered. Actually fix client side errors. #273

Closed JoshuaStorm closed 7 years ago

JoshuaStorm commented 7 years ago

So since forever now, we had been doing almost all of our handling upon routing, but I am pretty sure that's an antipattern. I believe from the get-go I wanted to do everything on rendered, this switches to doing that and it seems to work well. I suspect this may silently resolve some weird issues.

This PR also resolves the issues we had with the front end errors, also resolving #259 while I was at it

I think this PR should be tested pretty extensively. Try to break it! 👍

davidmelvin commented 7 years ago

I broke it!

I accepted an invite and it said I wasn't meetable for this window. Then I clicked the "x" and i got all these errors:

Exception in template helper: TypeError: Cannot read property 'readyToFinalize' of undefined
Exception in template helper: TypeError: Cannot read property 'participants' of undefined
Exception in template helper: TypeError: Cannot read property 'participants' of undefined

same error for 'title', duration and 'suggestedMeetingTimes'

JoshuaStorm commented 7 years ago

Darn. Thanks, I'll look into it!

davidmelvin commented 7 years ago

similar issues just on decline of an incoming invite

JoshuaStorm commented 7 years ago

Hmmm, I can't seem to quickly replicate these issues at the moment. I think I'll have to look into this tomorrow

JoshuaStorm commented 7 years ago

Oops, actually found the issue. I think I can resolve it pretty quick!

JoshuaStorm commented 7 years ago

Should be fixed now!