search

Joshuaalbert / jaxns

Probabilistic Programming and Nested sampling in JAX
https://jaxns.readthedocs.io/
Other
135 stars 9 forks source link

Is the Numpyro example still relevant? #142

Closed mvsoom closed 5 months ago

mvsoom commented 6 months ago

See https://num.pyro.ai/en/latest/examples/gaussian_shells.html. It doesn't work with latest numpyro/jaxns versions due to refactoring of jaxns. Is this intended to work? Cheers

Joshuaalbert commented 6 months ago

I'll take a look at the numpyro interface and fix it. It would work if the interface works. What's the error message?

mvsoom commented 6 months ago

Some "outdated" symbols cannot be imported from jaxns as they have been renamed etc. It is easy to fix in the source code by commenting it out, but then more fundamental things start to be missing, and without properly understanding jaxns source code, I gave up. But anyway, I am just using jaxns' PPL, and find it very convenient, so feel free to close this issue. Thanks for the excellent library.

Joshuaalbert commented 6 months ago

Glad that you're liking the probabilistic programming framework of JAXNS. Always glad to have feedback too. For numpyro update, @fehiepsi do you want me to do that?

fehiepsi commented 5 months ago

I think it is fixed in this PR. Because jaxns changes apis in each release, we typically pin the jaxns version in each release. Anyway, I'm happy to merge PRs that fix jaxns issues.

Joshuaalbert commented 5 months ago

Thanks @fehiepsi and fyi API should be fairly stable now.