Joshy837 / pe

0 stars 0 forks source link

Free Times that are able to be added overlaps with each other #7

Open Joshy837 opened 2 months ago

Joshy837 commented 2 months ago

How to reproduce: Key in addTime 1 ft/Mon:0800-1200, followed by `addTime 1 ft/Mon:0800-1201

Expected: Error message stating that timings are overlapped

Actual: Added the overlapped timings

image.png

nus-se-bot commented 2 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Free Time can be in between another free time

Description A contact could have these two free times be stored. Mon:0700-1500 and Mon:0900-1300. As the first free timeslot is a superset of the second, having the second free time stored gives users unnecessary information that might not be useful for a user to know.

Steps to reproduce addTime 1 ft/Mon:0700-1500 and Mon:0900-1300

Expected behaviour Should only add the superset and only reject extra time slots that are entirely within the time interval of another time slot.

Actual behaviour Accepts both free time slots.

Screenshots

image.png Bernice Yu has two timeslots where one is a superset of the other.

Reason for severity Low severity because a user can simply not add free times that they know are a subset of another free time


[original: nus-cs2103-AY2324S2/pe-interim#203] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

It is mentioned in the Planned Enhancements that we will support free time tag interval merging.

image.png

Overlapping free time intervals also include the above example which you have provided.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.Rejected`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]