Allow data.frames with unnecessary columns

JosiahParry / placekey

An R library to generate placekeys and interact with the placekey.io.

https://placekey.josiahparry.com

Other

17 stars 2 forks source link

Allow data.frames with unnecessary columns #3

Closed NickCH-K closed 4 years ago

NickCH-K commented 4 years ago

Currently, throws an error if get_placekey is given a data.frame that has any columns not strictly necessary for the Placekey call. This PR fixes the problem by adding ... as an argument to get_placekey and get_placekey.data.frame, which resolves the issue.

Also changes the README to refer to devtools::install_github() instead of devtools().

JosiahParry commented 4 years ago

Merging!

JosiahParry commented 4 years ago

@NickCH-K would like to add you as a contributor now :) can you make an additional PR with your info in the description?

NickCH-K commented 4 years ago

Sure, thanks!