search

JosiahParry / rsgeo

R bindings to the geo Rust crate
https://rsgeo.josiahparry.com/
Other
46 stars 5 forks source link

integrate with prepared geom #5

Closed michaelkirk closed 1 year ago

michaelkirk commented 1 year ago

I'm unfamiliar with R, and wasn't able to figure out how to run the R benchmarks.

There's an unfortunate clone, but I'd be curious to know if is this is an improvement for you.

michaelkirk commented 1 year ago

Also note that I pushed up a new commit to https://github.com/georust/geo/tree/mkirk/prepared-geom to allow you to build PreparedGeometry::from(geometry). Previously, it only supported PreparedGeometry::from(polygon).

JosiahParry commented 1 year ago

I can't find a PR for the PreparedGeometry so I'll leave some here. I think the two things that confuse me are

  1. how to interact with methods that are applied to the Geometry enum
  2. the lifetimes. Should i be slapping 'static everywhere? Would it be possible to have PreparedGeometry<T> for all Geometry types?