Closed JosiahParry closed 2 years ago
Hi @JosiahParry please assign this to me. I'd love to give it a try. Thank you
Claimed. I will work on it right away. Thank you
@opelolo awesome!
For the function definition in line 15, I'd suggest the arguments to be x
, y
, nb
, and wt
. Then the body of the function can be x * st_lag(y, nb, wt)
. Then, update the instances where local_moran_bv_calc()
is called
https://github.com/JosiahParry/sfdep/blob/45f8e539aba745358549497f70a335cf4f76f540/R/local-moran-bv-impl.R#L15
This calculation of the bivariate local moran is slow. It would be much more effecitve to calculate using
x * st_lag(y, nb, wt)
. See benchmark below.This can be replaced fairly simply. After changing
local_moran_bv_calc()
to includenb
argument,local_moran_bv_impl()
andlocal_moran_bv_perm_impl()
will need to be modified to use the new calculation.Created on 2022-08-05 by the reprex package (v2.0.1)