Josue87 / MetaFinder

Search for documents in a domain through Search Engines (Google, Bing and Baidu). The objective is to extract metadata
GNU General Public License v3.0
186 stars 32 forks source link

Update download.py #9

Closed alanEG closed 3 years ago

alanEG commented 3 years ago

redirect name file

:pushpin: References

To better handle the file name

:white_check_mark: Checklist

Josue87 commented 3 years ago

Hello @alanEG.

Thanks for you PR, I'll check it.

My first impression is that the error you mention does not occur, because the split is performed on a URL that must belong to a document, for example: https://wwww.example.com/test.pdf.

What you say is correct in case the URL ends with /. Did the error occur when running the tool?

What can be interesting in case of redirection is to get the last URL and save it, as you have done. I will try it when I have some time, and then I merge it.

Thanks!

alanEG commented 3 years ago

Hello @Josue87 Thanks you for quick replay you can test this case on samsung.com or manually on https://www.samsung.com/es/photopassbslegales/

Josue87 commented 3 years ago

Thanks @alanEG!

I have reviewed the Samsung example. And I could see what you were talking about.

Thank you!