Closed scruss closed 5 months ago
Thanks for the feedback. I've been trying to get the relevant info on screen with the rich Table interface but it has its own quirks when setting total and columns width. Ive indeed taken the simple approach to set the width to 110.
As this is an accessibility issue for you I will address this, but will likely need to drop, or abbreviate/ or fold some columns to fit to 80 characters.
Can you help by letting me know which of the columns are most relevant to you ?
Also - is there anything I should take into account wrt to the colors ?
I've been doing some testing with adjusting depending on the detected terminal width, would like your feedback on these
/dev/
if the console.width < 100 :
this results in :
┏━━━━━┳━━━━┳━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━┳━━━┓
┃Ser. ┃Fam.┃Port ┃Board ┃CPU ┃Version ┃Bld┃
┡━━━━━╇━━━━╇━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━╇━━━┩
│COM27│cpy │nRF52840│UNKNOWN_BOARD │nRF52840 │v8.2.10 │ │
│ │ │ │nice!nano with nRF52840 │ │ │ │
│COM8 │upy │samd │SEEED_WIO_TERMINAL │SAMD51P19A│v1.23.0-│341│
│ │ │ │Wio Terminal D51R with SAMD51P19A│ │preview │ │
└─────┴────┴────────┴─────────────────────────────────┴──────────┴────────┴───┘
note that the table is still only 99 chars wide; this is driven by the length of the descriptions.
Connected boards
┏━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━━━━┳━━━━━┓
┃Serial┃Family ┃Port ┃Board ┃CPU ┃Version ┃Build┃
┡━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━━━━━╇━━━━━┩
│COM27 │circuitpython│nRF52840│UNKNOWN_BOARD │nRF52840 │v8.2.10 │ │
│ │ │ │nice!nano with nRF52840 │ │ │ │
│COM8 │micropython │samd │SEEED_WIO_TERMINAL │SAMD51P19A│v1.23.0-preview│ 341│
│ │ │ │Wio Terminal D51R with SAMD51P19A│ │ │ │
└──────┴─────────────┴────────┴─────────────────────────────────┴──────────┴───────────────┴─────┘
if this works for you - then there is no need for now to drop any columns , and if I need to add Variant later, then it can probably be added in the Board column
Can you help by letting me know which of the columns are most relevant to you ?
Essential:
1. table.add_column("Serial", overflow="fold") 4. table.add_column("Board", overflow="fold") # Board _ID and description on separate lines 7. table.add_column("Version")
Useful (especially in truncated form):
2. table.add_column("Family")
Duplicated/implied in the Board column:
3. table.add_column("Port") 6. table.add_column("CPU")
Can't see a use for (and could quickly find out from the REPL):
8. table.add_column("build", justify="right") 5. table.add_column("Variant") # TODO: not a current column
Also - is there anything I should take into account wrt to the colors ?
I can't comment on how they work for other people, but they're good and contrasty here. I'm not a screen reader user, but I know a lot of screen readers get very shouty if they see bold or italics
Thanks, Ive made the Port and CPU columns drop out on terminals <100 characters. I use the Build to keep track of different preview versions - so Ill keep that , but its displayed only if there is any info in it.
The result is :
mpflash list
Connected boards
┏━━━━━┳━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┳━━━┓
┃Ser. ┃Fam.┃Board ┃Version ┃Bld┃
┡━━━━━╇━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━╇━━━┩
│COM27│cpy │UNKNOWN_BOARD │v8.2.10 │ │
│ │ │nice!nano with nRF52840 │ │ │
│COM8 │upy │SEEED_WIO_TERMINAL │v1.23.0-preview│341│
│ │ │Wio Terminal D51R with SAMD51P19A│ │ │
└─────┴────┴─────────────────────────────────┴───────────────┴───┘
Based on you comment about shouty screenreaders I did a quick test with Windows narrator and I found that the progress bar updates were leading to a highly annoying an repetitive narration. I could not hear a difference between Bold/Italics - so I've left these as is for now. I lowered the update frequency on that to find - what I think is a balance between visual and narrative updates.
Provide your feedback list output, though formatted, doesn't fit in a standard 80-column terminal
To Reproduce Steps to reproduce the behaviour:
xterm
, if it's installed, defaults to 80 columnsmpflash list
Expected behaviour Be able to see all columnar output in the terminal. It looks like it's hard-coded to use something like 110 columns. The scanning code respects terminal width. This is an accessibility issue for me.
Hardware Info Host
MCU
mpflash list --json
output: