Closed renovate[bot] closed 3 years ago
Latest commit: 535c2fd5fbefb759cb7e591282a9a7dafbeedfb7
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
This PR contains the following updates:
^2.0.4
->^3.0.0
GitHub Vulnerability Alerts
CVE-2021-21353
Impact
If a remote attacker was able to control the
pretty
option of the pug compiler, e.g. if you spread a user provided object such as the query parameters of a request into the pug template inputs, it was possible for them to achieve remote code execution on the node.js backend.Patches
Upgrade to
pug@3.0.1
orpug-code-gen@3.0.2
orpug-code-gen@2.0.3
, which correctly sanitise the parameter.Workarounds
If there is no way for un-trusted input to be passed to pug as the
pretty
option, e.g. if you compile templates in advance before applying user input to them, you do not need to upgrade.References
Original report: https://github.com/pugjs/pug/issues/3312
For more information
If you believe you have found other vulnerabilities, please DO NOT open an issue. Instead, you can follow the instructions in our Security Policy
Release Notes
pugjs/pug
### [`v3.0.1`](https://togithub.com/pugjs/pug/releases/pug@3.0.1) [Compare Source](https://togithub.com/pugjs/pug/compare/pug@3.0.0...pug@3.0.1) #### Bug Fixes - Sanitise the `pretty` option ([#3314](https://togithub.com/pugjs/pug/issues/3314)) If a malicious attacker could control the `pretty` option, it was possible for them to achieve remote code execution on the server rendering the template. All pug users should upgrade as soon as possible, see [#3312](https://togithub.com/pugjs/pug/issues/3312) for more details. ### [`v3.0.0`](https://togithub.com/pugjs/pug/releases/pug@3.0.0) [Compare Source](https://togithub.com/pugjs/pug/compare/pug@2.0.4...pug@3.0.0) #### Breaking Changes - `read` plugins must now return `Buffer` if you want to support filters that use `renderBuffer` ([#3213](https://togithub.com/pugjs/pug/issues/3213)) If you don't wish to support this advanced use case, you can continue returning `string`. If you did not provide a `read` plugin, you do not need to do anything. - The `minify` option on filters now requires you to install the relevant jstransformer ([#3084](https://togithub.com/pugjs/pug/issues/3084)) Currently we support: - jstransformer-uglify-js for JavaScript - jstransformer-clean-css for CSS - Drop support for node 6 and 8 ([#3243](https://togithub.com/pugjs/pug/issues/3243)) #### New Features - Support filters that apply to Buffers ([#3213](https://togithub.com/pugjs/pug/issues/3213)) e.g. ```js // options.js exports.filters = { png: { // instead of a function, specify an object with a "renderBuffer" property // whose value is a function that takes a Buffer instead of a string renderBuffer: function(buffer, options) { var data = Buffer.from(buffer).toString('base64'); return ''; } } }; ``` You can then use the filter like: ```pug // foo.pug include:png my-small-image.png ``` - Add support for replacing code gen via a plugin with `generateCode` ([#3230](https://togithub.com/pugjs/pug/issues/3230)) - Support `each ... of ...` loops ([#3179](https://togithub.com/pugjs/pug/issues/3179)) ```pug each value of iterable li= value ``` This requires an environment that supports the `for (const val of iterable)` syntax in JS. You can iterate over Maps, Sets etc. as well as arrays. There is also some destructuring of map keys: ```pug - const map = new Map([['a', 'x'], ['b', 'y']]); each [key, value] of map li strong= key = value ```Configuration
:date: Schedule: "" (UTC).
:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.
:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
:no_bell: Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by WhiteSource Renovate. View repository job log here.