search

Joven-Heng / pe

0 stars 0 forks source link

invalid date resulting in duplicated activity/accommodations. #6

Open Joven-Heng opened 3 years ago

Joven-Heng commented 3 years ago

When a user(me) decides to add an activity inside with an invalid date (I.E: 2021-02-31 10:10) 31st does not exist inside the month of Feburary. This results in

image.png being created.

Firstly, this is the wrong date(an incorrect date error should be thrown).

However, what is even more intriguing is if u now add a date (I.E: 2021-02-28 10:10), we should not be able to do so, since they are of the same date and same time,

But it is recognised by Wanderlust, resulting in 2 activities occuring at the same time. (this should not be allowed inside wanderlust as specified in UG)

Steps to recreate 1) go to wishlist 2)add -activity n/Universal Studios Singapore i/5 l/Sentosa c/88 d/2021-02-31 10:10 3)add -activity n/Universal Studios Singapore i/5 l/Sentosa c/88 d/2021-02-28 10:10

image.png

This error also occurs when we add to any travelplan (Be it activity or accommodation).

image.png

nus-se-bot commented 3 years ago

Team's Response

We feel that the bug should be considered as low severity as it does not affect the normal operations of the product, since the app does not crash and will still function as per normal as you can still navigate to your desired travel plan and continue to perform commands. Furthermore, it is rare for users to input an invalid date and the only inconvenience it may cause is having 2 activities that look the same in the UI.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]