search

JovianHQ / jovian-py

Collaboration platform for data science projects & Jupyter notebooks
https://www.jovian.ai
112 stars 31 forks source link

Dw/settings dialog #109

Closed RogodaThallus closed 4 years ago

RogodaThallus commented 4 years ago

Is now formatted, documented, and fully functional. With buttons, alerts, and tool tips.

PrajwalPrashanth commented 4 years ago

Can you merge with latest master and clear the conflicts

PrajwalPrashanth commented 4 years ago

@RogodaThallus Please check this image There are no buttons in the setting dialog

PrajwalPrashanth commented 4 years ago

Hey @RogodaThallus could you check, i think there is some bug still with opening up modal, when i clicked on SetDefaultParams the modal did not open up and when i clicked on ChangeApiKey suddenly all the modals opened up. image

Also disable is not working could you check that out too.

PrajwalPrashanth commented 4 years ago

Check if there is any change is notebook api as well. I'll also have a look into it.

codecov[bot] commented 4 years ago

Codecov Report

Merging #109 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #109   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines         1329      1329           
=========================================
  Hits          1329      1329
Flag Coverage Δ
#unittests 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1b636b6...1b636b6. Read the comment docs.