search

JovianHQ / jovian-py

Collaboration platform for data science projects & Jupyter notebooks
https://www.jovian.ai
112 stars 31 forks source link

commit dialog - new UI and match with the new arguments #111

Closed bendesu closed 4 years ago

bendesu commented 4 years ago

newUI

PrajwalPrashanth commented 4 years ago

What's Choose the type of notebook ...., is it privacy ?

bendesu commented 4 years ago

@PrajwalPrashanth If you choose to create a new notebook, then the disable attribute of "type of notebook" will be removed, and then you can choose your type.

Otherwise, if you are not creating a new notebook, then this option will be disabled.

bendesu commented 4 years ago

@PrajwalPrashanth also, if you choose to create a new notebook, then it will automatically disable the "Name of Jovian.ml project" option. same for the "git commit".

PrajwalPrashanth commented 4 years ago

The documentation for ui components are too large, you can make it concise by including top level information.

PrajwalPrashanth commented 4 years ago

Is settings modal integrated with this PR ?

bendesu commented 4 years ago

Is settings modal integrated with this PR ?

settings not yet integrate with this PR. Do you want me to do that? I can do that as well.

PrajwalPrashanth commented 4 years ago

Is settings modal integrated with this PR ?

settings not yet integrate with this PR. Do you want me to do that? I can do that as well.

No, you can let doug know that he can pull all these changes and to integrate the settings modal. In this PR you can set alert for setting button as well similar to open sidebar.

bendesu commented 4 years ago

Is settings modal integrated with this PR ?

settings not yet integrate with this PR. Do you want me to do that? I can do that as well.

No, you can let doug know that he can pull all these changes and to integrate the settings modal. In this PR you can set alert for setting button as well similar to open sidebar.

Sure, I will do so!