Lab Extension commit button - Githubissues

JovianHQ / jovian-py

Collaboration platform for data science projects & Jupyter notebooks

https://www.jovian.ai

112 stars 31 forks source link

Lab Extension commit button #162

Closed saboomayank closed 4 years ago

saboomayank commented 4 years ago

Successfully published Jupyter Lab Ext (commit only) package on npm - jovian-lab-ext-test v0.1.4
Updated dependencies for Jupyter Lab v2.0.2.
Updated gitignore to exclude Jupyter Lab config files.
Included the npm package as a .tgz file.
Updated README for Jupyter Lab Ext install and added requirements.
Made the npm package searchable through Jupyter Lab Ext Manager.

PrajwalPrashanth commented 4 years ago

I have removed

style/bootstrap.min.css
style/index.css
instances of the above in package.json
docs/itegrations/.Rhistory
labext.md
*.tgz

I have added

few error handling
review comments where names can be improved
review comments on very few functionality changes

@bendesu please go through them, you create a new PR for those changes. One more can you use const for variable which are not changing

@saboomayank Please create a new PR for Docs and publishing guide in our CONTRIBUTION.md

Important Please use prettier so that there will be no format changes, i think you guys forgot to install them in your new systems.

Great work! Thanks for neat internal documentation as well. 😄