Lab Extension: alertDialog, warnings

[PrajwalPrashanth]

• [x] Simplified API saved Message
• [x] alertDialog inside lab instead of browser alerts
• [x] Remove jovian link in api dialog
• [x] return tuples from commit.py to use in lab
• [x] lab shows warnings alongside successfull commit
• [x] click.echo's err=True writes to stderr, im not able to figure out how to suppress both stdout (other logs) and stderr so have removed it for now. This affects only the BG color of the error message, text remains in red.
• [x] Remove warnings from commit.py and collect from stderr
• [x] Implement for nb extension

[codecov[bot]]

Codecov Report

Merging #166 into master will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #166   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines         1272      1273    +1     
=========================================
+ Hits          1272      1273    +1     

Flag	Coverage Δ
#unittests	100.00% <100.00%> (ø)

Impacted Files	Coverage Δ
jovian/utils/commit.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eba2ab2...8a7d7f4. Read the comment docs.

[PrajwalPrashanth]

@aakashns Check it out! Apart from the discussion have made few more changes.

• As jupyter implicitly prints i have added a kwarg check to return the tuple.
• Some failed error were still logged to stdout, have changed to stderr
• import jovian would do print(update available) and break the extension some times have added a check
• replicated in nb extension as well

@rohitsanj I have made changes to test, can you verify them once.

[PrajwalPrashanth]

@rohitsanj i have added tests to make codecov 100% can you please verify them as well. Let me know if anything can be better there.

[PrajwalPrashanth]

Notebook warning

Lab Warning

[aakashns]

Thanks for adding screenshots. Some notes on how the UI can be improved:

• The "Warning!" text ideally shouldn't be bigger than the success message itself, to avoid confusion. Please make it smaller (both title & description).
• The exclamation mark in "Warning!" can be removed (causes anxiety). You can replace it with a triangular or circular icon
• Giving it some visual hints will help. You can use a similar color scheme as we use in the docs.

[PrajwalPrashanth]

Thanks for adding screenshots. Some notes on how the UI can be improved:

* The "Warning!" text ideally shouldn't be bigger than the success message itself, to avoid confusion. Please make it smaller (both title & description).

* The exclamation mark in "Warning!" can be removed (causes anxiety). You can replace it with a triangular or circular icon

* Giving it some visual hints will help.  You can use a similar color scheme as we use in the docs.

• Sure i will make changes to font size and remove the exclamation mark.
• Lets do the other UI related changes after the refactor of notebook extension ? As design is pending for all dialogs.

[aakashns]

Lets do the other UI related changes after the refactor of notebook extension ? As design is pending for all dialogs.

Sure, we can merge without the UI changes for now. Let me know here when this is ready for review.

[PrajwalPrashanth]

Its ready. I guess we can have these as a stop gap until we go with designs for extension dialogs. Added apt icons with apt colors.

[aakashns]

I've simplified the return statements a bit. Looks like one of the tests need to be updated

[aakashns]

Since the Jupyter extension check is not used for conditional return values, we don't need the Jupyter extension check at all (saving the file is a fairly minor check), so I've removed it and the related tests.

We can add it back later if some use case comes up

[PrajwalPrashanth]

@aakashns The current master would print out result like this.

Also i think you have updated prettier and the trailing comma and arrow parens got updated.

[aakashns]

Fair point, the URL gets printed twice, once in the log, and then again in the output. However, I think it's OK to return the URL as the output value from jovian.commit. It also gives the end-user a way of checking the result of commit or working with the uploaded notebook programmatically.

Regarding Prettier, we need a add a .prettierconfig file, as we have done in the webapp. I'll add it in a follow up PR