search

JovianHQ / jovian-py

Collaboration platform for data science projects & Jupyter notebooks
https://www.jovian.ai
112 stars 31 forks source link

fix environment capture on windows #168

Closed rohitsanj closed 4 years ago

rohitsanj commented 4 years ago

Used os.environ to get the name of conda environment instead of executing an echo command and capturing the output.

codecov[bot] commented 4 years ago

Codecov Report

Merging #168 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #168   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines         1276      1272    -4     
=========================================
- Hits          1276      1272    -4
Flag Coverage Δ
#unittests 100.00% <100.00%> (ø)
Impacted Files Coverage Δ
jovian/utils/environment.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d4cb387...821f6a0. Read the comment docs.

aakashns commented 4 years ago

Looks good, please add this check for CONDA_EXE too

rohitsanj commented 4 years ago

Looks good, please add this check for CONDA_EXE too

Done!