JovianHQ / jovian-py

Collaboration platform for data science projects & Jupyter notebooks
https://www.jovian.ai
112 stars 31 forks source link

Pass args to kaggle commit, handle / in project #192

Closed PrajwalPrashanth closed 4 years ago

PrajwalPrashanth commented 4 years ago
PrajwalPrashanth commented 4 years ago

@sidujjain @aakashns Need help testing it out. As mentioned in the description i have covered a bug and potential bugs.

codecov[bot] commented 4 years ago

Codecov Report

Merging #192 into master will increase coverage by 0.44%. The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #192      +/-   ##
==========================================
+ Coverage   99.11%   99.55%   +0.44%     
==========================================
  Files          29       29              
  Lines        1353     1356       +3     
==========================================
+ Hits         1341     1350       +9     
+ Misses         12        6       -6     
Flag Coverage Δ
#unittests 99.55% <83.33%> (+0.44%) :arrow_up:
Impacted Files Coverage Δ
jovian/utils/commit.py 97.15% <0.00%> (ø)
jovian/utils/kaggle.py 100.00% <100.00%> (+42.85%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 557b341...ccd883c. Read the comment docs.

aakashns commented 4 years ago

@PrajwalPrashanth can you please add unit test?