JovianHQ / jovian-py

Collaboration platform for data science projects & Jupyter notebooks
https://www.jovian.ai
112 stars 31 forks source link

get_conda_bin fix #199

Closed PrajwalPrashanth closed 4 years ago

PrajwalPrashanth commented 4 years ago

Reported Issue https://jovian.ml/forum/t/jovian-commit-not-working/7367

        conda_exe = os.environ.get("CONDA_EXE")
        # Check if it returns a valid path
        if conda_exe != '' and conda_exe != '$CONDA_EXE':

Previous check was for empty string where as conda_exe would be None if it did not find a valid path

codecov[bot] commented 4 years ago

Codecov Report

Merging #199 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #199   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines         1356      1356           
=========================================
  Hits          1356      1356           
Flag Coverage Δ
#unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jovian/utils/environment.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4a8ada9...4ab2db3. Read the comment docs.