search

JovianHQ / jovian-py

Collaboration platform for data science projects & Jupyter notebooks
https://www.jovian.ai
112 stars 31 forks source link

Show proper error message when 'jovian clone' is called for private or secret notebooks #206

Closed prabhat625 closed 4 years ago

prabhat625 commented 4 years ago

Summary:

1.Cloning the private notebook need collaborators to login first by providing the API key.

  1. Non authorize user should get the permission error message

Link to ClubHouse story:

Club house TIcket

Changes done in backend apiserver

This pull request

prabhat625 commented 4 years ago

Testing Result
libraryTest

prabhat625 commented 4 years ago

Result

When non-collaborator clone the private notebook

403

When the notebook owner clone the private notebook

result

PrajwalPrashanth commented 4 years ago

@prabhat625 There is a extra file settings.json for in this PR can you remove that.