search

JovianHQ / jovian-py

Collaboration platform for data science projects & Jupyter notebooks
https://www.jovian.ai
112 stars 31 forks source link

Maintain Directory Structure during clone #218

Closed prabhat625 closed 3 years ago

prabhat625 commented 3 years ago

Summary

Created a function to create a nesting directory.

Clubhouse Ticet

Ticket

Result

result result

PrajwalPrashanth commented 3 years ago

@prabhat625 some test cases are failing. Please check them out

prabhat625 commented 3 years ago

@PrajwalPrashanth Now All test cases are passed. Problem:- Our testing files don't have 'folder' key. Solution:- Instead f['folder'] we can use f.get('folder)

aakashns commented 3 years ago

@PrajwalPrashanth please review the updated PR

codecov[bot] commented 3 years ago

Codecov Report

Merging #218 into master will decrease coverage by 0.47%. The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
- Coverage   91.55%   91.07%   -0.48%     
==========================================
  Files          31       31              
  Lines        1456     1468      +12     
==========================================
+ Hits         1333     1337       +4     
- Misses        123      131       +8
Flag Coverage Δ
unittests 91.07% <33.33%> (-0.48%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jovian/utils/clone.py 85.00% <33.33%> (-7.05%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aed29bb...059dc5a. Read the comment docs.

aakashns commented 3 years ago

Thanks for taking this up. However, the implementation can be simplified significantly. I've done it in #232 , so closing this for now.