search

JovianHQ / jovian-py

Collaboration platform for data science projects & Jupyter notebooks
https://www.jovian.ai
112 stars 31 forks source link

Remove secret API Key input for Windows and allow corrupt notebooks to get cloned #219

Closed prabhat625 closed 3 years ago

prabhat625 commented 3 years ago

Summary

Added a check for the environment. If found windows and not inside Jupyter-notebook we don't hide API key.

Clubhouse ticket

Ticket

codecov[bot] commented 3 years ago

Codecov Report

Merging #219 (25e3488) into master (095a64e) will increase coverage by 0.31%. The diff coverage is 86.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #219      +/-   ##
==========================================
+ Coverage   91.55%   91.86%   +0.31%     
==========================================
  Files          31       31              
  Lines        1456     1476      +20     
==========================================
+ Hits         1333     1356      +23     
+ Misses        123      120       -3
Flag Coverage Δ
unittests 91.86% <86.20%> (+0.31%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jovian/utils/commit.py 90.71% <50.00%> (-0.70%) :arrow_down:
jovian/utils/clone.py 97.93% <92.30%> (+5.89%) :arrow_up:
jovian/_version.py 100.00% <100.00%> (ø)
jovian/utils/credentials.py 100.00% <100.00%> (ø)
jovian/utils/rcfile.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d8ed05e...25e3488. Read the comment docs.