search

JovianHQ / jovian-py

Collaboration platform for data science projects & Jupyter notebooks
https://www.jovian.ai
112 stars 31 forks source link

Notebook validation warning logs #224

Closed PrajwalPrashanth closed 3 years ago

PrajwalPrashanth commented 3 years ago

Dependent of backend PR: 468

image image

Works for colab notebooks too image

codecov[bot] commented 3 years ago

Codecov Report

Merging #224 (f555b11) into master (d6a73de) will decrease coverage by 0.14%. The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
- Coverage   94.01%   93.86%   -0.15%     
==========================================
  Files          31       31              
  Lines        1453     1467      +14     
==========================================
+ Hits         1366     1377      +11     
- Misses         87       90       +3
Flag Coverage Δ
unittests 93.86% <77.77%> (-0.15%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jovian/utils/colab.py 40.00% <20.00%> (-4.45%) :arrow_down:
jovian/utils/api.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d6a73de...10f7345. Read the comment docs.

aakashns commented 3 years ago

Please implement it in a backward-compatible fashion, so that it works for the old and the new backend. Also, there seems to be an unresolved comment, please resolve.