search

JovianX / helm-release-plugin

Helm3 plugin that pulls(re-creates) helm Charts from deployed releases, and updates values of deployed releases without the chart.
Apache License 2.0
97 stars 12 forks source link

Replace wget with curl #14

Closed rtpro closed 2 years ago

rtpro commented 2 years ago

wget is used in the installation process to get yq. As curl has a wider install-base and comes built in with more systems, we should be using curl to pull files instead of wget.

gangadharjannu commented 2 years ago

Why don't we mention yq as a dependency just like jq so that we can pre install yq before installing this plugin ?

Is there any specific reason why yq is being installed programmatically by script ?

rtpro commented 2 years ago

It was a dependency, exactly as jq is now, but it caused issues for some users:

  1. yq is not a common package, and in most cases is not present as part of the OS.
  2. yq supports only Snap packaging for Linux, which is not standard in some distros, making it harder to install.

Because of the above, we decided to ship its binary as part of the plugin installation, implemented by #4 .

rtpro commented 2 years ago

Addressed by PR #15 Thank you @gangadharjannu for the code contribution! 🙏