Closed Joxit closed 2 years ago
looks good to me, however these null
are a bit weird in these spots, I'm used to this method for example on annotations
:
ingress template
{{- if .Values.ingress.enabled -}}
...
...
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
name: {{ $fullName }}
labels:
{{- include "myapp.labels" . | nindent 4 }}
annotations:
{{- with .Values.ingress.annotations }}
{{- toYaml . | nindent 4 }}
{{- end }}
values.yaml
ingress:
enabled: false
ingressClassName: nginx
annotations: {}
hosts: []
tls: []
meaning that annotations
will be always rendered (but eventually might ends up empty {}
) and not have its entire presence behind a conditional.
this enables admins running kubernetes easier patching and whatnot.
cheers
Thanks for your feedback :smile: I did the change !
As requested by @masterkain I added the support for kubernetes ingress
Interesting use case when the ui is on a custom pathname:
fixes #1