Open KubaMikolajczyk opened 2 years ago
All of the changes done and addressed in video update below: https://www.loom.com/share/b8cba94a8c4e4274beb14a622242eebf?sharedAppSource=team_library Also link to figma changelog: https://www.figma.com/file/xm6vBdSnQDroc57rGfGtPM/Video-workspace?node-id=1378%3A93428 Link to final designs: https://www.figma.com/file/xm6vBdSnQDroc57rGfGtPM/Video-workspace?node-id=308%3A5753
Add new video to existing playlist Add existing video to an existing playlist Add NFT video to an existing playlist Edit thumbnail in video workspace flow
@dmtrjsg IMO, this needs to be split into 3 issues:
@KubaMikolajczyk for this ticket
New tickets:
@KubaMikolajczyk can you kindly add the Figma link to comments to this 👆 ticket.
Hey team! Please add your planning poker estimate with ZenHub @drillprop @eldiegod @rafalpawlow
I don't remember participating in a conversation about this component and I was wondering when did we agreed to use this solution?
On Monday Adam told me that the decision for this component is to use the standard dropdown component that we already have implemented for the select instead of context menu that I use here above, but after discussion today we discovered that this old dropdown for selects do not allow for multiselecting. So after some internal discussion with Adam & Tomasz and we see two options here:
If time is important here - I would go with option 1️⃣ it's easier. But if we choose 2️⃣ then it's not only updating designs respectively - its also component work + documentation. Wdyt?
@KubaMikolajczyk
I don't remember participating in a conversation about this component and I was wondering when did we agreed to use this solution?
- Correct, that was first time surfaced on the dev grooming meeting, when reviewing designs. The issue with multi-select list drop down, is how selected options are displayed. This is exacerbated with long(ish) names of playlists, and we thought that combobox for whitelisted members already solves this use case effectively.
Empty state for no playlist in video workspace flow created: https://www.figma.com/file/xm6vBdSnQDroc57rGfGtPM/Video-workspace?node-id=2509%3A162914
This issue will be tackled in #2392 👉
☝️ This part of the work is done so all here is finished. Now playlists use a combo box for selection so you can look them up by typing and selecting. Also pills under the combo box show result of selection. Figma: https://www.figma.com/file/xm6vBdSnQDroc57rGfGtPM/Video-workspace?node-id=2397%3A141091
Context
While testing playlist: Channel owner experience - users expressed a need to add videos to the playlist while uploading or editing a video. This will require us to update video workspace final designs and create appropriate user stories to it.
Scope
Design
Add uploaded video to existing playlist | Figma Edit video > add to existing playlist | Figma
Empty state>