Joystream / atlas

Whitelabel consumer and publisher experience for Joystream
https://www.joystream.org
GNU General Public License v3.0
100 stars 45 forks source link

CRTs: block revenue split if CRT is newly created or channel account contains no tokens #6292

Open mochet opened 4 months ago

mochet commented 4 months ago

Problem

I am pretty sure that I have seen now multiple creators issue a CRT and then immediately begin a revenue share--I think this is partly because the tutorial implies that the user should start a revenue split as the 3rd and final step of the CRT tutorial.

image

Note in the above screenshot in step 4 it is implied that I should start a revenue split to "complete" the tutorial/progress

In this particular example: https://gleev.xyz/channel/25946?tab=Token

This basically means the creator shot themselves in the foot:

Note: I am fairly certain I have seen this same thing happen multiple times now

Solution

  1. Change the tutorial slightly and perhaps make more visible how many tokens are actually in the revenue split--it should somehow be implied that if the current revenue is below some amount then it isn't really worth starting the revenue split just yet.
  2. Add some sort of warning specifically for newly created creator tokens (<7 days)
  3. Add some very specific warning for channels that currently have zero balance in their channel account or some very small balance.
  4. Perhaps issue a specific warning about 30 day long revenue splits that is more obvious to the end user--this is a very long revenue split and I am not sure that users are fully aware of the implications
mochet commented 4 months ago

There are multiple examples of this that I can see through the CRT directory--CRTs that have no market cap (i.e. no one bought the CRTs on the market), 0 revenue and have revenue shares open.

These are within the first 3 pages of the CRT section of Gleev, there are so out of 30 CRTs (issued since the 5th of may) approximately 23% have issued creator tokens with 0 revenue (this is presuming that some other channels didn't also launch revenue splits with just short enough timeframes that they already concluded)

bedeho commented 4 months ago

@dmtrjsg I think you need to tweak the execution on this onboarding flow, are you up for providing some steering? Probably just entirely dropping revenue splits is fine, most people will need time to accumulate enough JOY to even split it.

dmtrjsg commented 4 months ago

0 revenue and have revenue shares open. That is clearly a bug, we will look into it with @ikprk .

@bedeho wdyt on adding an extra task to the flow instead of dropping revenue split-> Advertise your token so there is at least one holder before Revenue split.

bedeho commented 4 months ago

wdyt on adding an extra task to the flow instead of dropping revenue split-> Advertise your token so there is at least one holder before Revenue split.

Really hard to say, how will you measure this? what counts as advertising?

ikprk commented 4 months ago

0 revenue and have revenue shares open. That is clearly a bug, we will look into it with

This would be a problem with revenue data that Atlas receives from Orion and displays it on the marketplace.

I've checked the channels provided in the examples and each one of them has non-zero allocation for their revenue shares