Joystream / atlas

Whitelabel consumer and publisher experience for Joystream
https://www.joystream.org
GNU General Public License v3.0
100 stars 45 forks source link

NFTs: Lost an auction, "withdraw your bid" but doesn't seem there is a way to do this #6303

Open mochet opened 4 months ago

mochet commented 4 months ago

Problem

I received a notification saying "withdraw your bid" image

Here is the UI on the page of the video/NFT/auction, there is no "withdraw bid" button anywhere image

It looks like the system account that receives NFT auction bids contains a balance of 593,578 $JOY https://joystream.subscan.io/account/j4To6jgKfy8MgiMRDXzd76ZXh6dmMtw5KPdECRNDAiueycmrS?tab=transfer

This seems to indicate that no one has ever "withdrawn their bid" to date? (EDIT: it looks like the withdraw button is just shown inconsistently)

Solution

There should be a dedicated page that shows all withdrawable bids for the user--and ideally the user should be able to submit a batched transaction that withdraws all of the bids in one action

mochet commented 4 months ago

This also seems to be the same issue on another NFT auction that I lost--there is no withdraw button so presumably there is 2k $JOY sitting in the system account as well as the bids of 3k, 4k, and 14k--meaning a total of like 20k $JOY is in the system account https://gleev.xyz/video/76015 image

mochet commented 4 months ago

Strangely, on this NFT: https://gleev.xyz/video/13121 I do get the withdraw last bid option:

image

dmtrjsg commented 4 months ago

@mochet

there's certainly a task that suggests showing all auction stats on a single page, but that was not designed. On bid withdrawal we will have a look as sounds pretty serious :/

ikprk commented 4 months ago

@mochet @dmtrjsg The Issue seems to be that we only consider an open auction when looking for previous bids, I just need a confirmation that the user can withdraw bids from english auctions (runtime extrinsic name suggests that it can be only used for open auction), if so fix with be included in the next release.

ikprk commented 4 months ago

@ignazio-bovo could you explain english auction logic, it looks like there isn't any tx to withdraw from it

ignazio-bovo commented 3 months ago

No you cannot withdraw bids from an english auction, it's not part of the logic by design. Top bid win and settlement happens after english auction has ended.

dmtrjsg commented 3 months ago

@ignazio-bovo does that mean that if the bid is losing, it eternally remains locked up? If that is the case perhaps we need to disable this type of auction..

ignazio-bovo commented 3 months ago

No English auction top bids are always refunded when there's a new top bid https://github.com/ignazio-bovo/joystream/blob/9dfa47145056392a5a3f7fa56db4a5e10190dc5f/runtime-modules/content/src/lib.rs#L2308

mochet commented 3 months ago

No English auction top bids are always refunded when there's a new top bid https://github.com/ignazio-bovo/joystream/blob/9dfa47145056392a5a3f7fa56db4a5e10190dc5f/runtime-modules/content/src/lib.rs#L2308

It appears that is the case as shown in this block: https://joystream.subscan.io/extrinsic/7478705-1 From what I can gather, new top bid was made, and previous bid was returned to bidder?

dmtrjsg commented 3 months ago

👉 Seems like we need to change the messaging to "Your bid was automatically withdrawn." in the app notifications and email.