Set the general, and specific, parameters for each proposal

[bwhm]

See #234

[bwhm]

Assumptions

Using the following ProposalParamemeters, that I interpret as outlined below:

pub struct ProposalParameters<BlockNumber, Balance> {
    /// During this period, votes can be accepted
    pub voting_period: BlockNumber,

    /// A pause before execution of the approved proposal. Zero means approved proposal would be
    /// executed immediately.
    pub grace_period: BlockNumber,

    /// Quorum percentage of approving voters required to pass the proposal.
    pub approval_quorum_percentage: u32,

    /// Approval votes percentage threshold to pass the proposal.
    pub approval_threshold_percentage: u32,

    /// Quorum percentage of voters required to slash the proposal.
    pub slashing_quorum_percentage: u32,

    /// Slashing votes percentage threshold to slash the proposal.
    pub slashing_threshold_percentage: u32,

    /// Proposal stake
    pub required_stake: Option<Balance>,
}

Say we have 50 CMs:

• approval_quorum_percentage means the absolute percentage required to pass. If this parameter is set to 60, this will return true as soon as 30 (not 31?) voters have voted yes.
• approval_threshold_percentage means that we require a percentage of the voters vote yes. If this parameter is set to 80, this will return true while more than 80% of the votes are yes. Regardless of the amount of votes.
  • 1/1, 5/6, 40/50(?) -> true
  • 0/1, 4/6, 39/50 -> false
• approval_quorum_percentage and slashing_quorum_percentage work the same way.
• approval_threshold_percentage and slashing_threshold_percentage work the same way.

For a proposal to pass, both approval_quorum_percentage and approval_threshold_percentage has to be true at the same time. Again, let:

• approval_quorum_percentage = 60
• approval_threshold_percentage = 80 Assume the following voting scenario, where yes=n and no=m means at a specific time, n CMs have voted approve, and m CMs have voted reject/slash. I further assume abstain just matters for approval_threshold_percentage: First vote in:
• yes=1 & no=0 -> false,true-> false 29 votes in:
• yes=29 & no=0 -> false,true-> false 37 votes in:
• yes=29 & no=8 -> false,false-> false 38 votes in:
• yes=30 & no=8 -> true,false-> false 40 votes in:
• yes=32 & no=8 -> true,true-> true

...the vote passes, and will be active after end of grace_period

Same logic for slashing, so we must ensure both cannot occur simultaneously.

General

"Default" values

• Setting voting_periodto 43200 (three days)
• Setting approval_* to 66% / 80%
• Setting slashing_* to 60% / 80%
• Setting required_stake to 0.25% (of issuance)

As for other values that needs to be correlated with the issuance, I'm setting required_stake as a percentage of issuance. This is probably ideal either, but should be better than a fixed value.

Evict Storage Provider

Proposal Parameters	Value
voting_period	43200
grace_period	0
approval_quorum_percentage	50%
approval_threshold_percentage	75%
slashing_quorum_percentage	60%
slashing_threshold_percentage	80%
required_stake	0.1%

Rationale:

• No reason to have a grace_period period
• The approval_quorum_percentage should be lower for good responsiveness, but require a higher approval_threshold_percentage if so.
• Slashing is a little dangerous here, as not so informed CMs could just check the current state, and assume the proposal is malicious. Will the storage tool log things like uptime% and frequency of expired provider @mnaamani ?
• required_stake could be quite low, as I see no reason to discourage these

Set Storage Role Params

Proposal Parameters	Value
voting_period	43200
grace_period	14400
approval_quorum_percentage	75%
approval_threshold_percentage	80%
slashing_quorum_percentage	60%
slashing_threshold_percentage	80%
required_stake	0.25%

Rationale:

• This proposal will affect the system, and thus requires more time to vote, and for storage providers to respond before becoming effective. It should still be a fairly "responsive" thing though.
• This will impact both inflation and status quo, so requires a larger approval rate.

Set Max Validator Count

Proposal Parameters	Value
voting_period	43200
grace_period	0
approval_quorum_percentage	66%
approval_threshold_percentage	80%
slashing_quorum_percentage	60%
slashing_threshold_percentage	80%
required_stake	0.25%

Rationale:

• As it's far easier to get a validator online, I don't think this requires a long grace_period.
• Even though inflation is not impacted, it could have a fairly large impact on incentives, so we should require a somewhat high approval percentage/rate.
• As we don't yet support a concept like higher threshold for larger (relative) changes, I think this is fair.

Set Lead

Proposal Parameters	Value
voting_period	43200
grace_period	0
approval_quorum_percentage	66%
approval_threshold_percentage	80%
slashing_quorum_percentage	60%
slashing_threshold_percentage	80%
required_stake	0.25%

Rationale:

• Although changing lead doesn't impact the system a lot, I think we should allow voters to listen to the arguments of each side instead of being forced to a quick decision. Three days might be enough though.
• No reason to have a grace_period, as the lead could cause harm during this period.
• This is actually a problem for this particular role, so in a perfect world, it would be nice to have a two round vote where the first would "suspend" the lead if passed.

Set WG Mint Capacity

Proposal Parameters	Value
voting_period	43200
grace_period	0
approval_quorum_percentage	50%
approval_threshold_percentage	75%
slashing_quorum_percentage	60%
slashing_threshold_percentage	80%
required_stake	0.25%

Rationale:

• This could require very quick changes in "emergencies", where the current curators could not get paid.
• As there is a cap on new funds, I think we could have a smaller approval_*.

Set Council Mint Capacity

Dropped Will not be implemented as a proposal.

Runtime Upgrade

Proposal Parameters	Value
voting_period	72000
grace_period	72000
approval_quorum_percentage	80%
approval_threshold_percentage	100%
slashing_quorum_percentage	60%
slashing_threshold_percentage	80%
required_stake	1%

Rationale:

• The most critical proposal.
• Setting a long voting_period to encourage research and discussion.
• Setting a long grace_period to avoid collapse, and allowing adjustments.
• Setting a higher approval_quorum_percentage, and 100% approval_threshold_percentage
• Slashing not affected, as there shouldn't really be opposing views on whether a proposal should be rejected for being "wrong" at the time, or actually "bad" as in malicious or greedy.

Set Election Parameters

Proposal Parameters	Value
voting_period	72000
grace_period	* +1
approval_quorum_percentage	66%
approval_threshold_percentage	80%
slashing_quorum_percentage	60%
slashing_threshold_percentage	80%
required_stake	0.75%

Rationale:

• Another way the CMs could enrich themselves by exploiting their power.
• Setting a long voting_period to encourage research and discussion.
• Setting a very long grace_period to allow the next council to revert any "bad" changes.
  • The * indicates this should match whatever cycle length we initially set Constantinople. (For rome, this would mean 201600)
  • If this can read the current newTermDuration from state, and add +1, that would be even nicer, but not worth the work IMO. Maybe add a note in the code?
• As the above should ensure CMs can't lock in the changes for themselves, I think default values are ok.

Spending Proposal

Proposal Parameters	Value
voting_period	72000
grace_period	14400
approval_quorum_percentage	66%
approval_threshold_percentage	80%
slashing_quorum_percentage	60%
slashing_threshold_percentage	80%
required_stake	0.25%

Rationale:

• Ideally, it would be possible to configure the grace_period for each spending proposal individually, but I suppose it can be solved by milestones and Text/signal Proposal
• Using a fairly high number for voting_period to allow for discussions, and a (short) grace_period to avoid inflation eating too much, while still giving the option to veto in case of abuse.

Text/signal Proposal

Proposal Parameters	Value
voting_period	72000
grace_period	0.
approval_quorum_percentage	66%
approval_threshold_percentage	80%
slashing_quorum_percentage	60%
slashing_threshold_percentage	80%
required_stake	0.25%

Rationale:

• As this is just a signaling thing, I'm really not sure what makes the most sense here.
• Numbers reflect the "need" to allow discussion only.

[bwhm]

Instead of updating the comment, I'm making a new comment. Won't elaborate here, just numbers:

Evict Storage Provider

Proposal Parameters	Value
voting_period	43200
grace_period	0
approval_quorum_percentage	50%
approval_threshold_percentage	75%
slashing_quorum_percentage	60%
slashing_threshold_percentage	80%
required_stake	25000

Set Storage Role Params

Proposal Parameters	Value
voting_period	43200
grace_period	14400
approval_quorum_percentage	66%
approval_threshold_percentage	80%
slashing_quorum_percentage	60%
slashing_threshold_percentage	80%
required_stake	100000

Set Max Validator Count

Proposal Parameters	Value
voting_period	43200
grace_period	14400
approval_quorum_percentage	66%
approval_threshold_percentage	80%
slashing_quorum_percentage	60%
slashing_threshold_percentage	80%
required_stake	100000

Set Lead

Proposal Parameters	Value
voting_period	43200
grace_period	0
approval_quorum_percentage	60%
approval_threshold_percentage	75%
slashing_quorum_percentage	60%
slashing_threshold_percentage	80%
required_stake	50000

Set WG Mint Capacity

Proposal Parameters	Value
voting_period	43200
grace_period	0
approval_quorum_percentage	60%
approval_threshold_percentage	75%
slashing_quorum_percentage	60%
slashing_threshold_percentage	80%
required_stake	50000

Runtime Upgrade

Proposal Parameters	Value
voting_period	72000
grace_period	72000
approval_quorum_percentage	80%
approval_threshold_percentage	100%
slashing_quorum_percentage	60%
slashing_threshold_percentage	80%
required_stake	1000000

Set Election Parameters

Proposal Parameters	Value
voting_period	72000
grace_period	100800
approval_quorum_percentage	66%
approval_threshold_percentage	80%
slashing_quorum_percentage	60%
slashing_threshold_percentage	80%
required_stake	200000

Spending Proposal

Proposal Parameters	Value
voting_period	72000
grace_period	14400
approval_quorum_percentage	60%
approval_threshold_percentage	80%
slashing_quorum_percentage	60%
slashing_threshold_percentage	80%
required_stake	25000

Text/signal Proposal

Proposal Parameters	Value
voting_period	72000
grace_period	0
approval_quorum_percentage	60%
approval_threshold_percentage	80%
slashing_quorum_percentage	60%
slashing_threshold_percentage	80%
required_stake	25000

[shamil-gadelshin]

Released.