search

Joystream / joystream

Joystream Monorepo
http://www.joystream.org
GNU General Public License v3.0
1.42k stars 115 forks source link

Update from node v14 to v18.6.0 #4778

Closed mnaamani closed 1 year ago

mnaamani commented 1 year ago

Updated all volta sections in repo package.json files to use node 18, as well is in github workflows and docker images. I did not change the min version in engine sections to prevent breaking any deployments where volta is not used or forcing users to upgrade. But as long as volta is used, it will trigger it to update and use new version.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Updated (UTC) | | :--- | :----- | :------ | :------ | | **pioneer-testnet** | ⬜️ Ignored ([Inspect](https://vercel.com/joystream/pioneer-testnet/CLZ1ifMQsQz5gGejekDySPZajDos)) | | Jul 20, 2023 8:21pm |
mnaamani commented 1 year ago

@zeeshanakram3 Applied your feedback, I also update Readme to document the fact that old version of linux will not support node v18, so I include a workaround.

zeeshanakram3 commented 1 year ago

Looks good, I think we should use the same nodes engine requirement (>=14.18.0) in all package.json files in monorepo.

mnaamani commented 1 year ago

@zeeshanakram3 Applied your feedback, I also update Readme to document the fact that old version of linux will not support node v18, so I include a workaround.

done in 4a985be