[Argus] Fix config parsing bug

Joystream / joystream

Joystream Monorepo

http://www.joystream.org

GNU General Public License v3.0

1.42k stars 115 forks source link

[Argus] Fix config parsing bug #4788

Closed zeeshanakram3 closed 1 year ago

zeeshanakram3 commented 1 year ago

addresses #4787

Addresses #4787 in 695c66a0b290bbd911e0c8ce988e7dd953919d6b. The fix allows omitting optional config keys from config.yml file when specifying their values as env vars.
add uri validation for endpoint properties in schema
bump avj version number

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

mnaamani commented 1 year ago

Would merging https://github.com/Joystream/joystream/pull/4759 without this fix be problematic?

zeeshanakram3 commented 1 year ago

Would merging #4759 without this fix be problematic?

The error fixed in this PR occurred if we didn't provide the required property of an optional object in config.yml. In #4759, a new property logs.elastic.index is being added, which is already optional. So I think we won't have an issue if we merge #4759 without this fix.