[Origo] Adds support to mark storage-node/distrubtion-node under maintenance

Joystream / joystream

Joystream Monorepo

http://www.joystream.org

GNU General Public License v3.0

1.42k stars 115 forks source link

[Origo] Adds support to mark storage-node/distrubtion-node under maintenance #4793

Open zeeshanakram3 opened 1 year ago

zeeshanakram3 commented 1 year ago

Addresses #4765

[x] Adds Storage/Distribution QN mappings
[x] Adds operator:set-metadata & leader:set-node-operational-status CLI commands
[x] ~WIP: Updating Storage/Distribution related integration tests~ https://github.com/Joystream/joystream/issues/4815

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

mnaamani commented 1 year ago

You need to add implicitly new dependency on inquirer-datepicker? (and maybe others) to storage node: this is why this check is failing building docker image for storage node https://github.com/Joystream/joystream/actions/runs/5561050023/jobs/10158465896?pr=4793#step:8:373

zeeshanakram3 commented 1 year ago

Integration tests will be added in #4815

mnaamani commented 1 year ago

@zeeshan perhaps we can try to bump version of protobufjs in this PR?

see https://github.com/advisories/GHSA-h755-8qp9-cq85

zeeshanakram3 commented 1 year ago

perhaps we can try to bump version of protobufjs in this PR?

Bumped package versions and updated CHANGELOG.md in d133ffb

mnaamani commented 1 year ago

perhaps we can try to bump version of protobufjs in this PR?

Bumped package versions and updated CHANGELOG.md in d133ffb

Great. I think QN package also needs a version bump.

zeeshanakram3 commented 1 year ago

I think QN package also needs a version bump.

Done in ba24cfe

zeeshanakram3 commented 6 months ago

@kdembler I have addressed the requested changes. Also, removed the QN mappings needed for this feature as I think having the code at two places makes it difficult to review and maintain

Also, did changes as described in #4816 for both Argus/Colossus

zeeshanakram3 commented 5 months ago

@mnaamani @kdembler I have addressed the requested changes. Also, re-designed the protobuf message schemas as requested.

If the new protobuf messages are acceptable, then please publish the npm package so I would update the storage-squid mappings as well

mnaamani commented 5 months ago

@mnaamani @kdembler I have addressed the requested changes. Also, re-designed the protobuf message schemas as requested.

If the new protobuf messages are acceptable, then please publish the npm package so I would update the storage-squid mappings as well

published protobuf and joystream/js packages (for joystream/js I bumped the dependency on protobuf package)