search

Joystream / joystream

Joystream Monorepo
http://www.joystream.org
GNU General Public License v3.0
1.42k stars 115 forks source link

Add recipient for TX fees from AMM #4837

Open ignazio-bovo opened 1 year ago

ignazio-bovo commented 1 year ago

Background

Currently in the PR outstanding #4750 The transaction fees are deposited into an account internal to the project_token pallet using an address for each token_id:

let amm_treasury_account = <T as Config>::ModuleId::get().into_sub_account_truncating(&("AMM", token_id))

Nothing much is possible to do with these funds and they are burned on amm deactivation (any amount exceeding existential deposit is burned to be correct)

Proposal

We want to redirect these funds to other recipient that can make use of them candidates:

bedeho commented 1 year ago

def. we want => creator channel internal account

ignazio-bovo commented 1 year ago

Also trading fees both on selling to amm and buying from amm are storage variables that are set via proposal: https://github.com/Joystream/joystream/pull/4696/files#diff-652a29e7e1d847e7bf20cf46d96f53d12eea786ccb0ac20f657817032dd0d9e4