search

Joystream / joystream

Joystream Monorepo
http://www.joystream.org
GNU General Public License v3.0
1.42k stars 115 forks source link

Fix/add validator mapping #4839

Closed chrlschwb closed 1 year ago

chrlschwb commented 1 year ago

fixes #4823

thesan commented 1 year ago

@zeeshanakram3 thank you for having a look.

We are now been committing the the generated graphql.schema files in both storage-node & distributor-node, it's basically done for the ease of generating the docker images of storage/distributor nodes, so it's fine (cc. @thesan)

I'll keep this in mind!

Q: If there is a isVerified field in the validator entity, then who will do the verification? And there there should be protobuf message for validator verification action too. (cc. @thesan)

The HR workers/lead will take care of the verification with their: workerRemark/leadRemark extrinsics. But that's in the scope of another issue: #4824.

The isVerified will always be false following a member creation or update event so IMO there is no need to add it to the Membership.proto.

@chrlschwb please don't close your PRs. If you didn't mean to merge master into it you can still reset your branch to 6d40bd7afd21f2c947eb0d04d6584ad0c4f3a0cb and force push or if you want to restart from scratch you can still do that and force push a new fix/addValidatorMapping.