Joystream / joystream

Joystream Monorepo
http://www.joystream.org
GNU General Public License v3.0
1.42k stars 115 forks source link

[WIP] Interop between our substrate fork and sygma supported substrate version #4850

Closed ignazio-bovo closed 5 months ago

ignazio-bovo commented 1 year ago

Scope

Detail the interoperability and possible issue due to sygma pallet substrate dependencies and our runtime dependencies on our custom forked substrate version on top of substrate 0.9.41

Custom substrate framework in use

We are currently using a forked version of the substrate framework: https://www.github.com/joystream/substrate For which we have modified the:

Sygma version we are using

??

This is due to the sygma pallets having different dependencies for sp-io than our pallets

Solution

The issue can be solved via specifying the correct version of sp-io (and other pallets that are common to our and sygma configuration, if necessary) in the root Cargo.toml (i.e. the workspace toml). We should specify the version used by sygma that is

sp-io v7.0.0 (https://github.com/paritytech/substrate?branch=polkadot-v0.9.39#8c4b8452)

The only pallet we should refer to our forked, patched one is the staking pallet:

pallet-staking = { package = 'pallet-staking', default-features = false, git = 'https://github.com/joystream/substrate.git', rev = '50cf239147a6f569e563bcadec6c7a1c5ad5c67e' }

For which we have custom locking logic. The sygma pallet don't seem to have dependency on pallet-staking so it should not produce any conflict

https://github.com/paritytech/subport/issues/150