QN mappings review & fixes

Joystream / joystream

Joystream Monorepo

http://www.joystream.org

GNU General Public License v3.0

1.42k stars 115 forks source link

QN mappings review & fixes #4856

Closed zeeshanakram3 closed 1 year ago

zeeshanakram3 commented 1 year ago

addresses https://github.com/Joystream/joystream/issues/4842

This PR:

fixes #4855
fixes #4853
Creates a new custom Eslint rule for disallowing the use of the throw keyword
Removes all instances of throw from the mappings and adds helper function getById & getByIdOrFail instead

mnaamani commented 1 year ago

@zeeshanakram3 I fixed conflicts and updated version here https://github.com/zeeshanakram3/joystream/pull/7 I would like to merge this to master soon, so I can updated nara branch from master soon.