search

Joystream / joystream

Joystream Monorepo
http://www.joystream.org
GNU General Public License v3.0
1.42k stars 115 forks source link

Fix/4824 verify validator #4868

Closed chrlschwb closed 11 months ago

chrlschwb commented 1 year ago

4824

zeeshanakram3 commented 1 year ago

This is not the actually testing the validator profile verification. To test this I think you would need to create a fixture like RemarkModeratePostsFixture. But that would be a lot of effort. @zeeshanakram3 in your opinion is this test worth the effort or can we skip it here ?

Yes, so I think the integration-test should be added for this action. Although, there isn't any specific place to add fixture for this specific action, but still I would say that add a new fixture VerifyVealidatorAccountFixture.ts in tests/network-tests/src/fixtures/membership.

After creating the new fixture, add a new flow (say validatorProfile.ts) in tests/network-tests/src/flows/membership, in which you would have to both first create a validator profile (most of the code from the updatingProfile flow will be reused) , and then after that do the validator verification using the VerifyVealidatorAccountFixture.ts fixture.

Last step, add the flow (validatorProfile.ts) to the tests/network-tests/src/scenarios/memberships.ts scenarios file. Make sure that this flow has dependency on the hireLeads job/flow.

cc. @chrlschwb