search

Joystream / joystream

Joystream Monorepo
http://www.joystream.org
GNU General Public License v3.0
1.42k stars 115 forks source link

Update nara from master #4872

Closed mnaamani closed 1 year ago

mnaamani commented 1 year ago

Looks like there I need to fix this:

✨ openapi-typescript 4.5.0
🔭 Loading spec from file:///Users/mokhtar/joystream/joystream/storage-node/src/api-spec/openapi.yaml…
🚀 ./src/api-spec/openapi.yaml -> /Users/mokhtar/joystream/joystream/storage-node/src/services/webApi/types/generated.ts [141ms]
$ tsc --build ./client/tsconfig.json
$ tsc --build tsconfig.json && mkdir -p ./lib/api-spec && cp ./src/api-spec/openapi.yaml ./lib/api-spec/openapi.yaml
src/services/runtime/extrinsics.ts:121:47 - error TS2352: Conversion of type 'SpRuntimeDispatchError' to type 'DispatchError' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.
  Types of property 'asToken' are incompatible.
    Type 'SpRuntimeTokenError' is missing the following properties from type 'TokenError': isUnderflow, isOverflow

121               error: formatDispatchError(api, e.data[0] as DispatchError),
                                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~

Found 1 error.
mnaamani commented 1 year ago

Fixed in https://github.com/Joystream/joystream/pull/4873 closing this.