search

Joystream / joystream

Joystream Monorepo
http://www.joystream.org
GNU General Public License v3.0
1.42k stars 115 forks source link

Bump to use newer version of Substrate #4918

Closed mnaamani closed 11 months ago

mnaamani commented 11 months ago

Do we need this?

https://github.com/paritytech/substrate/pull/13630

┆Issue is synchronized with this Asana task by Unito

mnaamani commented 11 months ago

The next polkadot substrate release which contains the updated trie-db v0.27.1 is v0.9.42 https://github.com/paritytech/polkadot/releases/tag/v0.9.42

mnaamani commented 11 months ago

After reviewing the changes in releases here: https://forum.polkadot.network/tag/release-analysis

I determined that the best version to update to at this time is 0.9.41 and manually bumping the trie-db to v0.27.1

I was tempted to just go straight to 0.9.43 even (current polkadot network release), however there are some high impact changes to the balances pallet. https://github.com/paritytech/substrate/pull/12951 which we would need to understand better to make sure it doesn't break any of the assumptions we make about joystream's staking mechanism with respect to reserved balances/locks and existential deposits.

So our forked version is at https://github.com/Joystream/substrate/commits/joystream-polkadot-v0.9.41-update built on-top of https://github.com/paritytech/substrate/tree/polkadot-v0.9.41 - compare the diff https://github.com/Joystream/substrate/compare/polkadot-v0.9.41...Joystream:substrate:joystream-polkadot-v0.9.41-update

This includes a fix for the staking pallet migration which removes a wrong post runtime upgrade migration assertion.

Implemented in https://github.com/Joystream/joystream/pull/4932