Update to polkadot v0.9.41

Joystream / joystream

Joystream Monorepo

http://www.joystream.org

GNU General Public License v3.0

1.42k stars 115 forks source link

Update to polkadot v0.9.41 #4932

Closed mnaamani closed 1 year ago

mnaamani commented 1 year ago

Fixes https://github.com/Joystream/joystream/issues/4918

update to use joystream substrate fork of polkadot-v0.9.41 branch + related fixes
Re-enable renaming pallet BagsList to VoterList to be inline with polkadot (to ensure polkadot-js apps staking app compatibility) after modifying the migration in substrate to skip "problematic" post upgrade check.
bump wasmtime crate to v6.0.2
bump trie-db to v0.27.1

┆Issue is synchronized with this Asana task by Unito

mnaamani commented 1 year ago

ref: https://github.com/Joystream/joystream/issues/4736#issuecomment-1753287924

The bump to wastime 6.0.2 is a security fix. It was part of the v0.9.43 polkadot release. I recommend we keep it. https://github.com/paritytech/polkadot/pull/7144
Asked about move_pallet / post upgrade assertion on substarte stackexchange

mnaamani commented 1 year ago

If the failing check is suggesting that the keys starting with old_prefix are not exactly removed from storage, does it imply that move_pallet actually performs a copy?

No, I'm pretty sure it does move based on looking at the implementation and testing the chain to confirm nothing was at the prefix anymore.