search

Joystream / joystream

Joystream Monorepo
http://www.joystream.org
GNU General Public License v3.0
1.42k stars 115 forks source link

[Nara] add freeze pallet proposal #4946

Closed freakstatic closed 1 year ago

freakstatic commented 1 year ago

Implements the proposal part of #4897

freakstatic commented 1 year ago

enum.type was wrong choice on my part, should be enum.toString() I believe you need to generate types one last time :) Finally I was surprised to see query-node/chain-metadata/1001.json and 2001.json modified then realized that was result of running yarn format in query-node workspace. I think we should add a query-node/.prettierignore with content:

chain-metadata/

@mnaamani yeah I also thought it was a bit strange but I assumed that it was ok to commit them formatted, should I revert that?

mnaamani commented 1 year ago

@mnaamani yeah I also thought it was a bit strange but I assumed that it was ok to commit them formatted, should I revert that?

Yes please. It just makes it easier to detect if they are truly modified when we fetch the metadata with yarn update-chain-metadata by simply doing git diff