Joystream / joystream

Joystream Monorepo
http://www.joystream.org
GNU General Public License v3.0
1.42k stars 115 forks source link

Argus: share video assets codec #4978

Closed attemka closed 9 months ago

attemka commented 9 months ago

Currently, there are no restrictions of the video asset encoding when Atlas user uploads a new file. However, some users are experiencing playback issues when the file has the unsupported codec. This issue should be solved by the transcoding, but since its only comes next year, according to our roadmap, it will be good to have an understanding of the codecs, which are causing the most issues. We tried to solve this on the client side in Atlas by using the mp4box, but unfortunately, it has some issues for mobile devices. So idea behind this issue would be to have the information about the video asset codec on the server-side and share it with the user in the response header, this way we can use either mp4box by gpac or ffmpeg (which we already using in monorepo in CLI). If the Argus performance would be noticeably affected by the ffmpeg\mp4box, maybe it'll worth it to add the codec info to the QN record of the asset.

bedeho commented 9 months ago

Backdrop

Thanks for writing this up.

My understanding is that the purpose of the current fix is only to collect data to inform what codecs people are trying to use, so as to inform later work on how to transcode. You have tried to collect this data on client side to detect failed playback, and log - and possibly also give some new UI treatment, but that does not reliably work. For t

Analysis

attemka commented 9 months ago

@bedeho ok, fair enough. anyways, we'll still have some logs from desktop clients, which should be enough for the transcoding data analysis. Closing this for now then.