temp folder refactor - Githubissues

mnaamani commented 9 months ago

Temp folder can now be configured with argument with a fully qualified path, with a check that it is not the same as the uploads folder.
Added check to ensure logs folder is not the same directory as the uploads folder.
Improved initialization of the uploads directory, reading data objects from the uploads folder filters out any files/subfolders without a name matching the data-object-id (ie. a number)
Improved initialization of temp directory. It will not be recursively deleted on startup (risky).
Renamed the 'dev' commands to 'util' commands although I have some reservation about using the cleanup command outside of the context of the running server.. Perhaps we should drop them.

mnaamani commented 9 months ago

Looks Good. Can you please add --tempFolder flag in docker-compose file, as an example on how to use it?

mnaamani commented 8 months ago

LGTM. I believe the version bump and CHANGELOG will be done in separate release PR?

Yes will do that next.

Joystream / joystream