[Colossus] Remove sync i/o calls

Joystream / joystream

Joystream Monorepo

http://www.joystream.org

GNU General Public License v3.0

1.42k stars 115 forks source link

[Colossus] Remove sync i/o calls #5054

Closed mnaamani closed 9 months ago

mnaamani commented 9 months ago

Fixes https://github.com/Joystream/joystream/issues/5050

Changed sync io to async io.
Did not add caching results of fileInfo.

mnaamani commented 9 months ago

Looks good, do you think it makes sense to do this change for the distributor-node too?

Any opportunity where it makes sense to eliminate blocking the event loop for too long should be investigated. I'm not as familiar with the distributor-node code base but yes in general it makes sense.

mnaamani commented 9 months ago

Did not add caching results of fileInfo.

Should I include this in the PR, it would reduce latency accessing files.

Edit: Added in 8bb4be3